[SSSD] [PATCH] Fix segmentation fault in test_io.

Abhishek Singh abhishekkumarsingh.cse at gmail.com
Fri Apr 12 21:08:45 UTC 2013


Please check this patch, previous patch contained extra changes which is
not required.


On Sat, Apr 13, 2013 at 2:30 AM, Abhishek Singh <
abhishekkumarsingh.cse at gmail.com> wrote:

> Required changes done. Please check the patch.
>
>
>
> On Fri, Apr 12, 2013 at 9:28 PM, Jakub Hrozek <jhrozek at redhat.com> wrote:
>
>> On Thu, Apr 11, 2013 at 01:47:03PM +0200, Lukas Slebodnik wrote:
>> > On (11/04/13 11:18), Jakub Hrozek wrote:
>> > >On Thu, Apr 11, 2013 at 11:04:06AM +0200, Lukas Slebodnik wrote:
>> > >> I wanted to revie som patches, but test failed with unrelated issue
>> to revieved
>> > >> patch.
>> > >>
>> > >
>> > >The test_io.c test should also call tests_set_cwd().
>> > >
>> > >Is this only an issue with test_io.c ? Did sysdb_tests run OK? I would
>> > >expect them to have the same problem, can you check?
>> >
>> > I fixed also tests_set_cwd(), there was ignored return value if
>> TEST_DIR is empty
>> > string. It should not happen with default TEST_DIR value.
>> >
>> > Attached patch just fix segmentation fault and improve some lines to
>> prevent
>> > segfault.
>> >
>> > Abhishek can rewrite test_io.c to using tests_set_cwd(),
>> > (use relative paths)
>> > Also there something what is not very good solution (transformation to
>> relativepath)
>> >
>> >     relativepath = strchr(get_filepath(path), 't');
>> >                                              ^^^^^
>> > What if I decide to call ./configure --with-test-dir="temp_test"?
>> >
>> > LS
>>
>> Lukas, please send a patch that would fix the above with calling basename,
>> please. We need to fix this in master asap.
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130413/09340b51/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-segmentation-fault-in-test_io.patch
Type: application/octet-stream
Size: 4142 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130413/09340b51/attachment.obj>


More information about the sssd-devel mailing list