[SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

Jakub Hrozek jhrozek at redhat.com
Fri Apr 12 17:17:11 UTC 2013


On Fri, Apr 12, 2013 at 04:59:28PM +0200, Jakub Hrozek wrote:
> On Tue, Apr 09, 2013 at 11:50:35AM -0500, Ariel Barria wrote:
> > 
> > > Hi Ariel,
> > > 
> > > you don't have to duplicate the case statements in a switch statement if
> > > both should yield the same result. Instead of:
> > > 
> > > +        case EPERM:
> > > +            DEBUG(SSSDBG_CRIT_FAILURE,
> > > +                 ("Not enough permission to read configuration file.\n"));
> > > +            break;
> > > +        case EACCES:
> > > +            DEBUG(SSSDBG_CRIT_FAILURE,
> > > +                 ("Not enough permission to read configuration file.\n"));
> > > +            break;
> > > 
> > > You can use:
> > > +        case EPERM:
> > > +        case EACCES:
> > > +            DEBUG(SSSDBG_CRIT_FAILURE,
> > > +                 ("Not enough permission to read configuration file.\n"));
> > > +            break;
> > 
> > Ok, thank you
> > 
> > > Also instead of "Not enough permission" I would rather say
> > > "Insufficient permissions".
> > 
> > 
> > I am hopeful ^_^
> > 
> > > Almost there :)
> > 
> > new patch
> >  		 	   		  
> 
> Ack!

Pushed to master.



More information about the sssd-devel mailing list