[SSSD] [PATCH] sss_cache: support for subdomains

Michal Židek mzidek at redhat.com
Wed Apr 10 15:55:45 UTC 2013


On 04/10/2013 04:06 PM, Jakub Hrozek wrote:
> On Mon, Apr 08, 2013 at 03:13:40PM +0200, Michal Židek wrote:
>> https://fedorahosted.org/sssd/ticket/1741
>>
>> Patch is attached.
>>
>> Thanks
>> Michal
>
> Almost ack :)
>
>
>> +    for (dinfo_list = tctx->domains; dinfo_list;
>> +         dinfo_list = get_next_domain(dinfo_list, false)) {
>> +        sysdb = dinfo_list->sysdb;
>> +        sysdb_update_subdomains(dinfo_list);
>
> Please check the return value here, print a debug message on failure and
> continue
>
> Can you add a comment atop this block of code? It's not very easy to
> understand:
>> +
>> +            if (main_domain) {
>> +                if (!dinfo->subdomains) {
>> +                    /* This domain has no subdomains */
>> +                    break;
>> +                }
>> +                main_domain = false;
>> +                dinfo = dinfo->subdomains;
>> +            } else {
>> +                dinfo = dinfo->next;
>> +            }
>> +        } while (dinfo);
>
> Otherwise I'm fine with the code.

New patch attached.

Thanks
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sss_cache-support-for-subdomains.patch
Type: text/x-patch
Size: 14599 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130410/aa0f5899/attachment.bin>


More information about the sssd-devel mailing list