[SSSD] SSSD Test Suite Coverage

Jakub Hrozek jhrozek at redhat.com
Wed Apr 10 12:23:12 UTC 2013


On Tue, Apr 09, 2013 at 12:13:44AM +0200, Jakub Hrozek wrote:
> On Tue, Apr 09, 2013 at 03:32:04AM +0530, Abhishek Singh wrote:
> > Hi Jakub,
> > 
> > Please check this patch.
> > 
> 
> Ack with a one change I can do myself before pushing, no need to
> re-send:
> 
> I would prefer if the get_filepath declaration didn't hardcode the array
> size, but rather looked like:
> 
> static char *get_filepath(char path[])
> 
> I think just stating that get_filepath() assumes that the buffer is big
> enough is OK for a unit test. But in real defensive code, I would prefer
> if the function had a second parameter to specify the size and allow
> checks on it.
> 
> But as I said above, I'll fix the get_filepath declaration before
> pushing and then push.
> 
> Thanks for the contribution!

Fixed the declaration and pushed to master.



More information about the sssd-devel mailing list