[SSSD] [PATCH] DHASH: Don't use backward jumps

Ondrej Kos okos at redhat.com
Fri Apr 5 12:02:18 UTC 2013


On 04/05/2013 01:52 PM, Lukas Slebodnik wrote:
> On (02/04/13 17:44), Ondrej Kos wrote:
>> https://fedorahosted.org/sssd/ticket/1855
>>
>> I couldn't let it this way when I saw the code :)
>> Patch is attached
>>
>> Ondra
>> --
>> Ondrej Kos
>> Associate Software Engineer
>> Identity Management
>> Red Hat Czech
>>
>> phone: +420-532-294-558
>> cell:  +420-736-417-909
>> ext:   82-62558
>> loc:   1013 Brno 1 office
>> irc:   okos @ #sssd #brno
>
>> diff --git a/dhash/dhash.h b/dhash/dhash.h
>> index baa0d6aa88b767b63018127c4ac454922fdd77d8..7f44c57f8091c70766c9d7fccb166e81b377721e 100644
>> --- a/dhash/dhash.h
>> +++ b/dhash/dhash.h
>> @@ -133,6 +133,14 @@ typedef enum
>>      HASH_ENTRY_DESTROY
>> } hash_destroy_enum;
>>
>> +typedef enum {
>> +    HI_STATE_0,
>> +    HI_STATE_1,
>> +    HI_STATE_2,
>> +    HI_STATE_3A,
>> +    HI_STATE_3B
>> +} hash_iter_state;
>> +
> This enum is only used in static function hash_iter_next().
> It is unnecessarily to be available in public API.
> I think that this typedef could be safety moved to implementation file dhash.c
>
>> typedef struct hash_key_t {
>>      hash_key_enum type;
>>      union {
>> --
>> 1.8.1.4
>>

Thanks for review Lukas,

New patch attached.

Ondra


-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DHASH-Don-t-use-backward-jumps.patch
Type: text/x-patch
Size: 3452 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20130405/d183eaba/attachment.bin>


More information about the sssd-devel mailing list