[SSSD] [PATCH] INI: Remove dead code

Ondrej Kos okos at redhat.com
Fri Apr 5 11:17:32 UTC 2013


On 04/04/2013 11:43 PM, Jakub Hrozek wrote:
> On Thu, Apr 04, 2013 at 01:11:23PM -0400, Dmitri Pal wrote:
>> On 04/04/2013 06:25 AM, Ondrej Kos wrote:
>>> On 04/03/2013 10:39 PM, Dmitri Pal wrote:
>>>> On 04/03/2013 07:36 AM, Ondrej Kos wrote:
>>>>> Hi,
>>>>>
>>>>> Issue found by coverity, the code itself was inaccessibile.
>>>>>
>>>>> https://fedorahosted.org/sssd/ticket/1857
>>>>>
>>>>> Patch is attached
>>>>>
>>>>> Ondra
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> sssd-devel mailing list
>>>>> sssd-devel at lists.fedorahosted.org
>>>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>>>
>>>>
>>>> Did the unit test work work fine with this patch?
>>>> Should be.
>>>> I read the code but did nit run it. Seems like a visual ack.
>>>
>>> Hi Dmitri,
>>>
>>> Yes, the tests are running smoothly. I thoroughly investigated and
>>> tested this part of code, and this condition would definitely take
>>> false branch every time.
>>
>> I know it is. I was just concerned about the validity of the adjustment
>> right above it. I think it is the correct adjustment that was added
>> later and thus the code after it became irrelevant but I forgot to
>> remove it.
>
> I think Ondra is right. It sounds to me like that check was added to
> stop cases where there is just whitespace before the equal sign but
> later there was another check added.
>
> I even tested the case by assigning "   = 1" to "str" and the first
> check stopped me.
>
> In other words, Ack
>

Pushed to master.


-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech



More information about the sssd-devel mailing list