[SSSD] [PATCH] Variable in sdap_sudo_rules_refresh_send could be used, uninitialised.

Michal Židek mzidek at redhat.com
Wed Sep 26 17:20:25 UTC 2012


Another one liner. If no rules were passed to 
sdap_sudo_rules_refresh_send (if rules[0] was NULL) and no error 
occurred, then variable ret was used uninitialized. This is not very 
likely to happen, but it is safer to have it initialized.

Maybe we should consider adding initialization of all "ret" variables to 
our coding guidelines to avoid these "unlikely but possible" errors in 
new code.

Patch attached.

Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Variable-in-sdap_sudo_rules_refresh_send-could-be-us.patch
Type: text/x-patch
Size: 791 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120926/79df2d63/attachment.bin>


More information about the sssd-devel mailing list