[SSSD] [PATCH] Add provider specific default regular expressions

Pavel Březina pbrezina at redhat.com
Thu Sep 20 08:19:38 UTC 2012


On 09/19/2012 09:49 PM, Sumit Bose wrote:
> Hi,
>
> this patch add specific default values for the regular expression to
> split user names for the AD and IPA provider. In a perfect patch the
> ID provider itself would report back what he would like to use as a
> regular expression, but all solutions I could think of would require
> some bigger changes to the startup process which are not suitable at
> this stage of the 1.9 development. So I picked a more direct solution.
>
> bye,
> Sumit
>
> @@ -130,6 +191,8 @@ int sss_names_init(TALLOC_CTX *mem_ctx, struct confdb_ctx *cdb,
>   #endif
>       }
>
> +    DEBUG(SSSDBG_TRACE_INTERNAL, ("Using re [%s].\n", ctx->re_pattern));
> +
>       ret = confdb_get_string(cdb, ctx, conf_path,
>                               CONFDB_FULL_NAME_FORMAT, NULL, &ctx->fq_fmt);
>       if (ret != EOK) goto done;
> -- 1.7.7.6

Hi,
can you consider using a lower debug level here? Maybe 
SSSDBG_CONF_SETTINGS? I think this information can be useful when 
helping customers, so we should make sure it is present in the logs.

Otherwise the code looks good.



More information about the sssd-devel mailing list