[SSSD] [PATCH] 1371-Missing resolv.conf should be non-fatal

Ariel Barria olivares73 at hotmail.com
Thu Sep 13 03:18:11 UTC 2012



hi, new patch :).

Apparently was required also monitor_config_file_fallback().

> Hi Ariel,
> 
> actually I reread the patch and I think there is a simpler way to fix
> the ticket..directly in the monitor_config_file() function, there is
> already a stat() call:
> 1823     ret = stat(file, &file_stat);
> 1824     if (ret < 0) {
> 1825         err = errno;
> 1826         DEBUG(0, ("Could not stat file [%s]. Error [%d:%s]\n",
> 1827                   file, err, strerror(err)));
> 1828         return err;
> 1829     }
> 
> 
> So I think that simply extending the error handler with special-casing
> ENOENT as you had in your patch would work fine:
> +        if (ret == ENOENT) {
> +            DEBUG(SSSDBG_MINOR_FAILURE,
> +                 ("file [%s] is missing, but will skip this check.\n",
> +                 RESOLV_CONF_PATH));
> +        } else {
> +            DEBUG(SSSDBG_MINOR_FAILURE,("Could not stat file [%s]. Error [%d:%s]\n",
> +                  RESOLV_CONF_PATH, ret, strerror(ret)));
> +        }
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120912/921e4c6e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-1371-Missing-resolv.conf-should-be-non-fatal.patch
Type: text/x-patch
Size: 6467 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120912/921e4c6e/attachment.bin>


More information about the sssd-devel mailing list