[SSSD] [PATCHES] change responder contexts hierarchy

Jakub Hrozek jhrozek at redhat.com
Tue Oct 30 14:24:43 UTC 2012


On Fri, Oct 19, 2012 at 12:27:44PM +0200, Pavel Březina wrote:
> 0001: do not leak memory on failure in *_process_init()
> 
> 0002: https://fedorahosted.org/sssd/ticket/1575
> 
> 0003: free request table as the first thing when deallocating rctx
> Because we have changed the hierarchy we do not need to special case
> responder shut down in dp request destructor anymore. More
> information may be found in the list archive:
> https://lists.fedorahosted.org/pipermail/sssd-devel/2012-October/011663.html
> 
> 0004: just a little coding style fix

> [PATCH 1/4] do not leak memory on failure in *_process_init()

If sss_process_init failed, in the per-responder _process_init functions,
you would free a random pointer.

> [PATCH 2/4] change responder contexts hierarchy

Looks good to me and sanity testing passed as well. I have applied the
patches and will them on my laptop until the other comments are fixes to
test them in a real environment.

> [PATCH 3/4] free request table as the first thing when deallocating rctx

Isn't the order guaranteed by the talloc itself?

> [PATCH 4/4] coding style fix

Ack



More information about the sssd-devel mailing list