[SSSD] [PATCH] do not default fullname to gecos when schema = ad

Pavel Březina pbrezina at redhat.com
Tue Oct 30 11:55:55 UTC 2012


On 10/30/2012 11:11 AM, Sumit Bose wrote:
> On Fri, Oct 26, 2012 at 04:18:28PM +0200, Pavel Březina wrote:
>> On 10/25/2012 12:27 PM, Sumit Bose wrote:
>>> On Thu, Oct 18, 2012 at 01:11:00PM +0200, Pavel Březina wrote:
>>>> https://fedorahosted.org/sssd/ticket/1482
>>>
>>>
>>> ... you add fullname to the user_attrs. Then sysdb_add_basic_user() will
>>> set fullname==gecos when it initially creates the user object in the
>>> cache, but it will be overwritten in the same transaction when
>>> sysdb_store_user() add all the user_attrs.
>>
>> Hi,
>> that's a good idea. I'm sending the patch. I did not test it though,
>> because I need to leave now. But it is pretty straightforward so I
>> hope it's OK.
>
> Can you use sysdb_attrs_get_string() instead of sysdb_attrs_get_el()?
> This would automatically cover the case where el->num_values != 1.
>
> bye,
> Sumit

Sure. Patch is attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-do-not-default-fullname-to-gecos-when-schema-ad.patch
Type: text/x-patch
Size: 1823 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20121030/05b6008e/attachment.bin>


More information about the sssd-devel mailing list