[SSSD] [PATCH] Remove libsss_sudo.pc and move libsss_sudo.so out of devel subpackage

Jakub Hrozek jhrozek at redhat.com
Tue Oct 9 18:24:45 UTC 2012


Hi,

I noticed during the work on provider packaging that we still ship the
libsss_sudo.pc file and that we only ship the libsss_sudo.so library in
the -devel package. I think that's wrong. We might also want to move
libsss_sudo out of LDPATH in the future, but that's not really important
now (and it would require coordination with sudo).

I decided to keep libsss_sudo-devel around because it still contains the
developer documentation.
-------------- next part --------------
>From 2e14578eb58d1f6e5a37a93016125ddac579ea48 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 28 Sep 2012 09:26:03 +0200
Subject: [PATCH 1/2] Couple of specfile fixes

---
 contrib/sssd.spec.in | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index e10899322921258b5a5d312ec0a39c8800c313a0..b6803eafff2244aca77c232210ad06542e52b192 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -147,8 +147,11 @@ Requires: sssd = %{version}-%{release}
 Provides userspace tools for manipulating users, groups, and nested groups in
 SSSD when using id_provider = local in /etc/sssd/sssd.conf.
 
-Also provides a userspace tool for generating an obfuscated LDAP password for
-use with ldap_default_authtok_type = obfuscated_password.
+Also provides several other administrative tools:
+    * sss_cache to expire cached entries
+    * sss_debuglevel to change the debug level on the fly
+    * sss_seed which pre-creates a user entry for use in kickstarts
+    * sss_obfuscate for generating an obfuscated LDAP password
 
 %package -n libsss_idmap
 Summary: FreeIPA Idmap library
@@ -158,7 +161,7 @@ Requires(post): /sbin/ldconfig
 Requires(postun): /sbin/ldconfig
 
 %description -n libsss_idmap
-Utility library to SIDs to Unix uids and gids
+Utility library to convert SIDs to Unix uids and gids
 
 %package -n libsss_idmap-devel
 Summary: FreeIPA Idmap library
@@ -486,6 +489,7 @@ A utility library to allow communication between Autofs and SSSD
 %{_libdir}/libsss_sudo.so.*
 
 %files -n libsss_sudo-devel
+%defattr(-,root,root,-)
 %if 0%{?fedora}
 %doc libsss_sudo_doc/html
 %endif
-- 
1.7.11.4

-------------- next part --------------
>From f61ea90a57476b79935f51604b27486e0488391f Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 28 Sep 2012 12:43:56 +0200
Subject: [PATCH 2/2] Remove libsss_sudo.pc and move libsss_sudo.so to
 libsss_sudo

---
 Makefile.am                           |  1 -
 configure.ac                          |  1 -
 contrib/sssd.spec.in                  |  4 +---
 src/sss_client/sudo/libsss_sudo.pc.in | 12 ------------
 4 files changed, 1 insertion(+), 17 deletions(-)
 delete mode 100644 src/sss_client/sudo/libsss_sudo.pc.in

diff --git a/Makefile.am b/Makefile.am
index 46e44d9f47f554bc1b856fbd721761b39c1edfd3..ee7e198f1d609ce2d9a81f7e9562ee2e5c93966b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1187,7 +1187,6 @@ libsss_sudo_la_LDFLAGS = \
     -version-info 2:0:1
 
 sudolib_LTLIBRARIES = libsss_sudo.la
-dist_pkgconfig_DATA += src/sss_client/sudo/libsss_sudo.pc
 
 include_HEADERS += \
     src/sss_client/sudo/sss_sudo.h
diff --git a/configure.ac b/configure.ac
index aabf375ced2c8bf74040fb55bb59be5d715ca507..9ee5844f789dc75221f96f0d46b4b7716419c95e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -272,7 +272,6 @@ AC_CONFIG_FILES([Makefile contrib/sssd.spec src/examples/rwtab src/doxy.config
                  src/sysv/systemd/sssd.service po/Makefile.in src/man/Makefile
                  src/providers/ipa/ipa_hbac.pc src/providers/ipa/ipa_hbac.doxy
                  src/lib/idmap/sss_idmap.pc src/lib/idmap/sss_idmap.doxy
-                 src/sss_client/sudo/libsss_sudo.pc
                  src/sss_client/sudo/sss_sudo.doxy
                  src/config/setup.py
                  src/config/SSSDConfig/__init__.py])
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index b6803eafff2244aca77c232210ad06542e52b192..e194245d166c7dee2f1988019b414e5fb47df2de 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -486,7 +486,7 @@ A utility library to allow communication between Autofs and SSSD
 %files -n libsss_sudo
 %defattr(-,root,root,-)
 %doc src/sss_client/COPYING src/sss_client/COPYING.LESSER
-%{_libdir}/libsss_sudo.so.*
+%{_libdir}/libsss_sudo.so*
 
 %files -n libsss_sudo-devel
 %defattr(-,root,root,-)
@@ -497,8 +497,6 @@ A utility library to allow communication between Autofs and SSSD
 %doc libsss_sudo_doc/html
 %endif
 %{_includedir}/sss_sudo.h
-%{_libdir}/libsss_sudo.so
-%{_libdir}/pkgconfig/libsss_sudo.pc
 
 %files -n libsss_autofs
 %defattr(-,root,root,-)
diff --git a/src/sss_client/sudo/libsss_sudo.pc.in b/src/sss_client/sudo/libsss_sudo.pc.in
deleted file mode 100644
index a739dc42ab101fc9af7334fda0f00094524a2cae..0000000000000000000000000000000000000000
--- a/src/sss_client/sudo/libsss_sudo.pc.in
+++ /dev/null
@@ -1,12 +0,0 @@
-prefix=@prefix@
-exec_prefix=@exec_prefix@
-libdir=@libdir@
-includedir=@includedir@
-
-Name: sss_sudo
-Description: A library to allow communication between SUDO and SSSD
-Version: @VERSION@
-Libs: -L at sudolibpath@ -lsss_sudo
-Cflags:
-URL: http://fedorahosted.org/sssd/
-
-- 
1.7.11.4



More information about the sssd-devel mailing list