[SSSD] [PATCH] do not check for POLLERR, POLLHUP, POLLNVAL when reading data

Pavel Březina pbrezina at redhat.com
Fri Oct 5 08:48:51 UTC 2012


On 10/04/2012 04:22 PM, Simo Sorce wrote:
> On Thu, 2012-10-04 at 13:03 +0200, Pavel Březina wrote:
>>  From 7c49fe46a3fbce1433ad1680a2e12335542706ed Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
>> Date: Thu, 4 Oct 2012 11:42:59 +0200
>> Subject: [PATCH 1/3] do not check for POLLERR, POLLHUP, POLLNVAL when
>> reading
>>   data
>>
>> According to the poll manpage, those error are valid only for
>> output only.
>>
> Ah btw I wanted to ask what you mean with this comment in the commit
> message.
>
> When 'reading' the flags after the poll returns we are in the 'output'
> situation, but from the way you wrote the comment to me it reads like
> you mention 'output' as meaning 'write event' (ie POLLOUT) ?
>
> Simo.
>

Oh, ignore anything I wrote before please. I completely misunderstood 
the documentation.

I'm sending new patch. It special cases POLLHUP. If it occurs, we will 
read the pipe and then close fd on the client side.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-do-not-fail-if-POLLHUP-occurs-while-reading-data.patch
Type: text/x-patch
Size: 1773 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20121005/6490c98a/attachment.bin>


More information about the sssd-devel mailing list