[SSSD] [PATCH] Log possibly non-randomizable ccache file template
Ondrej Kos
okos at redhat.com
Thu Oct 4 09:49:54 UTC 2012
On 10/04/2012 11:11 AM, Jakub Hrozek wrote:
> On Thu, Oct 04, 2012 at 08:13:36AM +0200, Ondrej Kos wrote:
>>> I'd like to see two more changes:
>>> 1) Don't pass the whole krb5child_req structure to
>>> cc_be_check_existing(), it's enough to just pass the option value or
>>> if we needed more options the whole options structure.
>>>
>> As we discussed it with Michal, we decided to pass whole structure,
>> since we're using three of its members now, but no problem, changed.
>
> Yeah, it's mostly about keeping the interface unobfuscated so that the
> caller can see what's being passed in and the interface can also be
> reused in code that doesn't know the child_req structure.
>
>>> 2) Rename the function from cc_file_check_template to something that
>>> doesn't include _file_ and make it static.
>> done
>>
>> fixed patch attached
>>
>> O.
new patch attached
O.
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
phone: +420-532-294-558
cell: +420-736-417-909
ext: 82-62558
loc: 1/5C Brno office
irc: okos @ #brno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Log-possibly-non-randomizable-ccache-file-template.patch
Type: text/x-patch
Size: 5557 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20121004/a3f886ae/attachment.bin>
More information about the sssd-devel
mailing list