[SSSD] [PATCH] Log possibly non-randomizable ccache file template

Michal Židek mzidek at redhat.com
Wed Oct 3 13:25:46 UTC 2012


On 10/03/2012 03:09 PM, Ondrej Kos wrote:
> On 10/03/2012 01:56 PM, Ondrej Kos wrote:
>> On 10/03/2012 01:48 PM, Ondrej Kos wrote:
>>> On 10/02/2012 07:03 PM, Ondrej Kos wrote:
>>>> fixes https://fedorahosted.org/sssd/ticket/1533
>>>>
>>>> ccache file template is now checked for appended XXXXXX for use with
>>>> mkstemp. When those characters are not present, warning is written to
>>>> log.
>>>>
>>>> patch is attached
>>>>
>>>> O.
>>>>
>>> self NACK
>>>
>>> We discussed it with Michal off-list and found that comparison was
>>> faulty - taken from krb5_auth code, so fixed there as well. Also i
>>> changed headers of affected functions not to pass so many (futile)
>>> arguments. new patch attached.
>>>
>>> O.
>>>
>> self NACK again, Michal confused me! code in krb5_child was ok, so
>> working patch attached.
>>
> Another off-list discussion, faulty condition.
> new patch attached
>
> O.
>
>

Looks good to me now.

ACK.

Michal




More information about the sssd-devel mailing list