[SSSD] [PATCHES] sss_seed related patches

Pavel Březina pbrezina at redhat.com
Mon Oct 1 17:45:17 UTC 2012


On 10/01/2012 06:25 PM, Michal Židek wrote:
> Patch 01: The debug_level variable was set before the parameters were
> processed, so the default debug level was used no matter what number was
> specified with --debug.
>
> Patch 02: When interactive input fails, error message should be displayed.
> https://fedorahosted.org/sssd/ticket/1549
>
> Patch 03: When file is used to specify a password in sss_seed, then only
> first line of this file is used. Also empty passwords are treated as
> errors. (My local test environment is broken so I have not tested this,
> please test it when reviewing.)
> https://fedorahosted.org/sssd/ticket/1548
>
> Patches are in attachment.
>
> Michal

Patch 1: nack
Instead of moving debug level initialization further in the code, you 
should parse the parameters earlier. The other tools uses following pattern:
- set debug program name
- set locale
- parse parameters
- set debug level
See sss_groupadd for example.

Patch 2: ack
Patch 3: I'll do this one tomorrow.



More information about the sssd-devel mailing list