[SSSD] [PATCH] Document ldap_chpass_update_last_change

Jakub Hrozek jhrozek at redhat.com
Mon Oct 1 16:17:44 UTC 2012


On Mon, Oct 01, 2012 at 04:57:17PM +0200, Pavel Březina wrote:
> On 10/01/2012 04:44 PM, Jakub Hrozek wrote:
> >On Mon, Oct 01, 2012 at 03:22:15PM +0200, Pavel Březina wrote:
> >>On 10/01/2012 12:29 AM, Jakub Hrozek wrote:
> >>>The option was missing from manual pages and the configAPI.
> >>>                  <varlistentry>
> >>>+                    <term>ldap_chpass_last_change (bool)</term>
> >>>+                    <listitem>
> >>>+                        <para>
> >>>+                            Specifies whether to update the
> >>>+                            ldap_user_shadow_last_change attribute with
> >>>+                            days since the Epoch after a password change
> >>>+                            operation.
> >>>+                        </para>
> >>>+                        <para>
> >>>+                            Default: False
> >>>+                        </para>
> >>>+                    </listitem>
> >>>+                </varlistentry>
> >>
> >>Nack.
> >>Isn't the option ldap_chpass_*update*_last_change?
> >
> >Yes, that's a typo..thanks!
> 
> Sorry, one more nack. It is also missing in __init__.py.in.

Thank you for the careful review. A new patch is attached.
-------------- next part --------------
>From 512a01aa31c9813e6260a0f56bb6f6de65b0d06b Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 28 Sep 2012 07:55:32 +0200
Subject: [PATCH] Document ldap_chpass_update_last_change

Add the option to the manual page and the configAPI

https://fedorahosted.org/sssd/ticket/1494
---
 src/config/SSSDConfig/__init__.py.in     |  1 +
 src/config/etc/sssd.api.d/sssd-ldap.conf |  1 +
 src/man/sssd-ldap.5.xml                  | 15 +++++++++++++++
 3 files changed, 17 insertions(+)

diff --git a/src/config/SSSDConfig/__init__.py.in b/src/config/SSSDConfig/__init__.py.in
index b90a8e100e38279c934b5a36ee87062d15eba4b6..0c48f55233352abbc0010e20de65fc606fb7a90d 100644
--- a/src/config/SSSDConfig/__init__.py.in
+++ b/src/config/SSSDConfig/__init__.py.in
@@ -304,6 +304,7 @@ option_strings = {
     'ldap_chpass_uri' : _('URI of an LDAP server where password changes are allowed'),
     'ldap_chpass_backup_uri' : _('URI of a backup LDAP server where password changes are allowed'),
     'ldap_chpass_dns_service_name' : _('DNS service name for LDAP password change server'),
+    'ldap_chpass_update_last_change' : _('Whether to update the ldap_user_shadow_last_change attribute after a password change'),
 
     # [provider/ldap/sudo]
     'ldap_sudo_search_base' : _('Base DN for sudo rules lookups'),
diff --git a/src/config/etc/sssd.api.d/sssd-ldap.conf b/src/config/etc/sssd.api.d/sssd-ldap.conf
index 8b3afb5b0a84640a84997a733d62dffdc6e02584..3b6b4e8fb6b09cebf7e2651f021d4b082040ff5b 100644
--- a/src/config/etc/sssd.api.d/sssd-ldap.conf
+++ b/src/config/etc/sssd.api.d/sssd-ldap.conf
@@ -127,6 +127,7 @@ ldap_access_order = str, None, false
 ldap_chpass_uri = str, None, false
 ldap_chpass_backup_uri = str, None, false
 ldap_chpass_dns_service_name = str, None, false
+ldap_chpass_update_last_change = bool, None, false
 
 [provider/ldap/sudo]
 ldap_sudo_search_base = str, None, false
diff --git a/src/man/sssd-ldap.5.xml b/src/man/sssd-ldap.5.xml
index f8cf8f2336d82175d5be9ee6fa7f5be77701593b..00acc89683c98b44e43cf7f060fa8aac6c7183d1 100644
--- a/src/man/sssd-ldap.5.xml
+++ b/src/man/sssd-ldap.5.xml
@@ -1620,6 +1620,21 @@
                 </varlistentry>
 
                 <varlistentry>
+                    <term>ldap_chpass_update_last_change (bool)</term>
+                    <listitem>
+                        <para>
+                            Specifies whether to update the
+                            ldap_user_shadow_last_change attribute with
+                            days since the Epoch after a password change
+                            operation.
+                        </para>
+                        <para>
+                            Default: False
+                        </para>
+                    </listitem>
+                </varlistentry>
+
+                <varlistentry>
                     <term>ldap_access_filter (string)</term>
                     <listitem>
                         <para>
-- 
1.7.11.4



More information about the sssd-devel mailing list