[SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

Pavel Březina pbrezina at redhat.com
Mon Nov 26 15:51:20 UTC 2012


On 11/14/2012 03:01 PM, Simo Sorce wrote:
> In some case we allocate and assign data to a const pointer.
> When we then try to free it we would get a const warning because talloc_free
> accepts a void, not a const void pointer. Use discard_const to avoid the
> warning, it is safe in this case.
> ---
>   src/util/util.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/util/util.h b/src/util/util.h
> index 66bae505df2779dbfc065a09162fd789fef9e835..e85facb92bb4de8d9eeaf97716e1aac252f9b32c 100644
> --- a/src/util/util.h
> +++ b/src/util/util.h
> @@ -228,7 +228,7 @@ errno_t set_debug_file_from_fd(const int fd);
>   #define FLAGS_PID_FILE 0x0004
>
>   #ifndef talloc_zfree
> -#define talloc_zfree(ptr) do { talloc_free(ptr); ptr = NULL; } while(0)
> +#define talloc_zfree(ptr) do { talloc_free(discard_const(ptr)); ptr = NULL; } while(0)
>   #endif
>
>   #ifndef discard_const_p
>

Hi,
I don't see any warnings without this patch on F17 with 
libtalloc-devel-2.0.7-4.fc17.x86_64. Does this patch apply to specific 
version?



More information about the sssd-devel mailing list