[SSSD] [PATCH] idmap: Silence DEBUG messages when dealing with built-in, SIDs.

Michal Židek mzidek at redhat.com
Wed Nov 21 14:00:07 UTC 2012


On 11/21/2012 11:04 AM, Jakub Hrozek wrote:
> On Tue, Nov 20, 2012 at 03:20:06PM +0100, Pavel Březina wrote:
>> We should propagate the built-in sid error instead of misusing id. Maybe
>> return IDMAP* directly and return errno value in new output parameter.
>>
>
> I actually think that using a special ID value is OK. We've been
> treating the UID and GID 0 as a special case before anyway for the fake
> users and groups. Also sdap_idmap_sid_to_unix() is supposed to return
> errno and not IDMAP* anyway, so even if we introduced a new IDMAP*
> return code, we would have to translate it into an (errno, id) tuple.
>
> The NSS responder would skip groups with a zero GID anyway.
>

I let this as it was in the previous patch. The other things are fixed.

New patch attached.

Thanks
Michal



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-idmap-Silence-DEBUG-messages-when-dealing-with-built.patch
Type: text/x-patch
Size: 6730 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20121121/e065a3f5/attachment.bin>


More information about the sssd-devel mailing list