[SSSD] [PATCHES] sss_userdel and sss_groupdel should invalidate mmap cache

Ondrej Kos okos at redhat.com
Wed Nov 21 12:06:40 UTC 2012


On 11/20/2012 02:29 PM, Michal Židek wrote:
> On 11/20/2012 02:22 PM, Michal Židek wrote:
>> Patch 1: sss_cache refactor. See patch description for more details.
>> Patch 2: Remove mmap cache properly in sss_userdel and sss_groupdel
>>
>> Patches are attached.
>>
>> Thanks
>> Michal
>>
>>
>>
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>>
>
> https://fedorahosted.org/sssd/ticket/1659
>
> I modified the commit message of second patch to include link to the
> ticket.
>
> Thanks
> Michal
>
>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
[PATCH 1/2]:
nitpick: git am warns about empty line at EOF

+        ret = sss_memcache_clear_all();
+        DEBUG(SSSDBG_CRIT_FAILURE, ("Failed to clear memory cache.\n"));
+        goto done;

the debug message will print every time, aren't you supposed to test ret 
and print it on != EOK ?

[PATCH 2/2]:
Ack

-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

phone: +420-532-294-558
cell:  +420-736-417-909
ext:   82-62558
loc:   1013 Brno 1 office
irc:   okos @ #brno



More information about the sssd-devel mailing list