[SSSD] [PATCH] TESTS: Fix a couple of debug-level setters

Jakub Hrozek jhrozek at redhat.com
Tue Nov 13 11:46:44 UTC 2012


On Tue, Nov 13, 2012 at 09:47:23AM +0100, Jan Cholasta wrote:
> On 12.11.2012 14:34, Jakub Hrozek wrote:
> >On Fri, Nov 09, 2012 at 10:31:13AM +0100, Jan Cholasta wrote:
> >>On 8.11.2012 20:10, Jakub Hrozek wrote:
> >>>Please see the attached patch. It wasn't possible to set the debug level
> >>>of tests easily, which made debugging them hard.
> >>>
> >>
> >>The following tests also do not produce any debugging output (tested
> >>with -d 10): ad_ldap_opt-tests, check_and_open-tests, debug-tests,
> >>find_uid-tests, ipa_hbac-tests, ipa_ldap_opt-tests,
> >>pac_responder-tests, sss_idmap-tests, strtonum-tests, util-tests.
> >
> >None of the above tests use the popt argument parsing library so they
> >don't have the -d option either. The attached patch only fixed the tests
> >that had the -d option but did not use it correctly.
> 
> strtonum-tests and util-tests do use popt actually.
> 

Right and they directly assign to the debug_level variable, the
assignment is just obfuscated behind the SSSD_MAIN_OPTS and
SSSD_DEBUG_OPTS macros. The reason why you didn't see any DEBUG messages
is simply because the functions being tested don't print any
debugging..

> >
> >We should fix the other tests as well, but it's not a priority right now.
> >
> 
> OK. ACK then.

Thank you, pushed to master only.



More information about the sssd-devel mailing list