[SSSD] [PATCH] Display more information on DB version crash

Jan Cholasta jcholast at redhat.com
Thu Nov 8 18:01:33 UTC 2012


Hi,

On 8.11.2012 15:05, Ondrej Kos wrote:
> https://fedorahosted.org/sssd/ticket/1589
>
> patch is attached
>
> O.
>

1) I think monitor and responders should use a different error message, 
excluding "If greater version is expected, run SSSD ...". Telling users 
to run SSSD when they in fact have it running might be confusing for 
someone.

It might be even better to have different error messages for when the 
version is greater than expected and when the version is lesser than 
expected (not sure how hard it would be to implement that).

2) You should check for EMEDIUMTYPE in sss_cache.c and tools_util.c 
right after sysdb_init_domain_and_sysdb is called IMO.

3) I would prefer if you did not suppress logging of debug messages when 
ret == EMEDIUMTYPE.

Honza

-- 
Jan Cholasta



More information about the sssd-devel mailing list