[SSSD] [PATCHES] Improve group handling for subdomain users

Simo Sorce simo at redhat.com
Thu Nov 8 14:44:40 UTC 2012


On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
> +static errno_t
> +pac_save_memberships_delete(struct pac_save_memberships_state *state)
> +{

[...]

> +    for (c = 0; c < pr_ctx->del_gid_count; c++) {
> +        ret = sysdb_search_group_by_gid(state,
> state->group_dom->sysdb,
> +                                        pr_ctx->del_gids[c], NULL,
> &group);

Wouldn't it be more efficient to create a search filter that lists all
GIDs we are interested in and do a single search rather than looping
over and over ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list