[SSSD] [PATCHES] Improve group handling for subdomain users

Simo Sorce simo at redhat.com
Thu Nov 8 14:34:19 UTC 2012


On Wed, 2012-11-07 at 13:13 +0100, Sumit Bose wrote:
> 
> This patch adds a new call which compares a list of current GIDs with
> a
> list of new GIDs and return a list of GIDs which are currently missing
> and must be added and another list of GIDs which are not used anymore
> and must be deleted. The method is the same as used by
> diff_string_lists().
> ---
>  src/responder/pac/pacsrv.h       |   10 +++
>  src/responder/pac/pacsrv_utils.c |  155
> ++++++++++++++++++++++++++++++++++++++
>  src/tests/pac_responder-tests.c  |  104 +++++++++++++++++++++++++-
>  3 files changed, 267 insertions(+), 2 deletions(-)
> 
> diff --git a/src/responder/pac/pacsrv.h b/src/responder/pac/pacsrv.h
> index e088e21..08172f8 100644
> --- a/src/responder/pac/pacsrv.h
> +++ b/src/responder/pac/pacsrv.h
> @@ -106,4 +106,14 @@ errno_t get_pwd_from_pac(TALLOC_CTX *mem_ctx,
>                           struct PAC_LOGON_INFO *logon_info,
>                           struct passwd **_pwd,
>                           struct sysdb_attrs **_attrs);
> +
> +errno_t get_gids_to_add_and_remove(TALLOC_CTX *mem_ctx,
> +                                   size_t current_gid_count,
> +                                   gid_t *current_gids,
> +                                   size_t gid_count,
> +                                   gid_t *gids,
> +                                   size_t *_add_gid_count,
> +                                   gid_t **_add_gids,
> +                                   size_t *_del_gid_count,
> +                                   gid_t **_del_gids); 

Can you change the function name to diff_gid_lists() ?


Also may be nice to change the following arg names:
current_gid_count -> cur_gid_num
current_gids -> cur_gid_list
gid_count -> new_gid_num
gids -> new_gid_list
_add_gid_count -> _add_gid_num
_add_gids -> _add_gid_list
_del_gid_count -> _del_gid_num
_del_gids -> _del_gid_list

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list