[SSSD] [PATCH 0/5] Fix various tevent_req style and naming issues

Simo Sorce simo at redhat.com
Wed Nov 7 19:18:44 UTC 2012


On Tue, 2012-11-06 at 09:07 +0100, Jakub Hrozek wrote:
> On Wed, Oct 31, 2012 at 06:37:30PM -0400, Simo Sorce wrote:
> > While I was working on an unrelated patchset I couldn't help fixing some
> > of the code to properly use tevent_req style and naming conventions.
> > 
> 
> I think the krb5_auth code is so old that it predates the tevent_req
> style. Up until now nobody simply stepped up to do the refactoring :)

Here am I :-)

> > This will bring this code in line with our tevent_req coding style and
> > hopefully make it more readable to eyes used to the tevent_req style.
> > It also fixes use of some inconsistent function names.
> > 
> > The krb5_auth.c changes are a bit tricky because I needed to change the
> > flow in several places and built helper functions to reduce a bit some
> > of the long functions.
> > 
> > I have been careful to make sure I did not change the actual program flow
> > and the patches work fine for me, so I am now dropping the RFC and asking
> > for review and inclusion in master.
> 
> In general it would be nice to also change the DEBUG levels. The amount of
> refactored code is quite big, so maybe not change all, that is outside the
> scope of this patch but change the occurences of DEBUG(1) and DEBUG(9) ?

I thought about it, but the churn is already high, and changing debug
levels will add yet another thing to carefully check for.

I would rather address that problem in a separate patch in this specific
case. If the refactoring weren't so large I'd do it gladly.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list