[SSSD] [PATCH] PAM: Do not leak fd after SELinux context file is written

Jakub Hrozek jhrozek at redhat.com
Thu Nov 1 19:44:30 UTC 2012


https://fedorahosted.org/sssd/ticket/1619

We don't close the fd when we write the selinux login file in the pam
responder. This results in a fd leak.
---
 src/responder/pam/pamsrv_cmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c
index 2b20544d1baf78ade232f93a2c91378ec6a7645c..bb0d8db384cbbc8a3beed5dc5be0fe32956992a9 100644
--- a/src/responder/pam/pamsrv_cmd.c
+++ b/src/responder/pam/pamsrv_cmd.c
@@ -443,6 +443,7 @@ static errno_t write_selinux_login_file(const char *username, char *string)
     } else {
         ret = EOK;
     }
+    close(fd);
     fd = -1;
 
 done:
-- 
1.7.12.1




More information about the sssd-devel mailing list