[SSSD] [PATCH] IPA subdomains - ask for information about master domain

Jan Zeleny jzeleny at redhat.com
Thu May 31 19:35:49 UTC 2012


Jakub Hrozek <jhrozek at redhat.com> wrote:
> On Wed, May 30, 2012 at 12:34:26PM +0200, Jan Zelený wrote:
> > This functionality will be utilized by PAC responder once it lands in the
> > master branch. One round of review already done by Sumit. Also the patch
> > has been tested together with the PAC responder.
> > 
> > The query is performed only if there is missing information in the
> > cache. That means this should be done only once after restart when cache
> > doesn't exist. All subsequent requests for subdomains won't include the
> > request for master domain. This is done to save time since it is not
> > possible to change this information once IPA server is installed.
> > 
> > https://fedorahosted.org/sssd/ticket/1351
> > 
> > Thanks
> > Jan
> 
> Why is IPA_SUBDOMAINS_SEARCH_BASE set twice in ipa_get_id_options() ?

copy-paste error, sorry for that

> In which cases is the be_req->sysdb set and when not? Can you add a
> comment?
> +        sysdb = (be_req->sysdb)?be_req->sysdb:be_req->be_ctx->sysdb;

It is used in my other patch, I guess I got confused while implementing both 
at the same time. In this case sysdb will be always taken from be_ctx.

> I always forget if we still keep documenting the low level IPA options such
> as search bases..anyway, ipa_subdomains_search_base is included in
> configAPI and manpage, but the newly added ipa_master_domain_search_base
> is not.

Oh man, how did I grep through the file while looking for it I don't know ... 
the new option should be there as well of course. As for documentation, I 
don't think we want to document this, setting it can only break things.

Patch with all three issues addressed is in attachment.

Thanks
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-133-1master-domain.patch
Type: text/x-patch
Size: 20397 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120531/09f64f57/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120531/09f64f57/attachment.sig>


More information about the sssd-devel mailing list