[SSSD] [PATCH] sysdb: return proper error code from sysdb_sudo_purge_all

Jakub Hrozek jhrozek at redhat.com
Thu May 10 18:36:19 UTC 2012


This is the last bug that was reported by clang and not Coverity. Some
of those that clang reported are also reported by Coverity and have
their own tickets (#1330-#1333).

I missed it in the first run because there was the same bug elsewhere in
the same file, I just didn't realize clang was reporting two instances
of the same problem.
-------------- next part --------------
>From 1a88318531cd2359603ba8673de70b22de47684d Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Tue, 8 May 2012 15:33:17 +0200
Subject: [PATCH] sysdb: return proper error code from sysdb_sudo_purge_all

---
 src/db/sysdb_sudo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/db/sysdb_sudo.c b/src/db/sysdb_sudo.c
index 8f396ef5c5445e5c250bdfeecbdc7369bf0bfb4b..b1f181aab9b3d715d139966a13ecb59d01156e8a 100644
--- a/src/db/sysdb_sudo.c
+++ b/src/db/sysdb_sudo.c
@@ -505,7 +505,7 @@ errno_t sysdb_sudo_purge_all(struct sysdb_ctx *sysdb)
     ret = EOK;
 done:
     talloc_free(tmp_ctx);
-    return EOK;
+    return ret;
 }
 
 errno_t sysdb_sudo_purge_byname(struct sysdb_ctx *sysdb,
-- 
1.7.7.6



More information about the sssd-devel mailing list