[SSSD] [PATCH] Per-domain re_expression and full_name_format

Stef Walter stefw at gnome.org
Tue May 8 05:59:01 UTC 2012


On 04/24/2012 11:43 AM, Jakub Hrozek wrote:
> On Tue, Apr 24, 2012 at 08:36:32AM +0200, Stef Walter wrote:
>> On 04/23/2012 09:00 PM, Simo Sorce wrote:
>>> Doesn't this end up running potentially the same regex over and over for
>>> each domain we have configured ?
>>> Wouldn't it make sense to detect how many different regexes we actually
>>> have (in the default case just one, the same for all domains) and just
>>> run them once ? Then we can sort out which of the domains using that
>>> regex is being addressed ...
>>> or is there something I am missing ?
>>
>> Yes that could be a nice optimization ... if we are in fact matching
>> more than a handful of regexes (ie: configured domains).
>>
>> But that brings to mind another related point. How are other 'trusted'
>> domains in the forest handled, and does this patch break them? Is there
>> somewhere in SSSD that handles arbitrary domain names, and figures out
>> which configured domain they go to. How does that work?
>>
>> For example let's say I have a domain 'ad.thewalter.lan' configured in
>> sssd which is part of a trust relationship with 'other.thewalter.lan'.
>> 'other.thewalter.lan' is not a configured sssd domain. How do we resolve
>> user names for other.thewalter.lan?
>>
>> If this is correctly handled, then I guess I missed consideration of
>> this in my patch. Pointers to the where this logic lives in sssd would
>> be nice.
>>
> 
> Hi Stef,
> the trusted domain appear as subdomains in SSSD. The subdomains support
> is currently on the list on review:

Integrated subdomain support into the patch.

Along the lines of what Simo said, all subdomains use the regular
expression of the parent domain and we only match the regular expression
once for those cases.

Thanks for the other reviews too. Updated patch attached.

I'd appreciate help testing this. I don't know how to reach all the code
paths involved.

Cheers,

Stef
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-re_expression-and-full_name_format-per-domain-o.patch
Type: text/x-patch
Size: 33110 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120508/cb9028cb/attachment.bin>


More information about the sssd-devel mailing list