[SSSD] [PATCH] Use keytab to select etypes for krb5_get_init_creds_keytab()

Jakub Hrozek jhrozek at redhat.com
Mon May 7 12:12:51 UTC 2012


On Mon, May 07, 2012 at 12:02:22PM +0200, Stef Walter wrote:
> On 05/07/2012 11:52 AM, Stef Walter wrote:
> > It seems that when using krb5_get_init_creds_keytab(), if we don't have
> > a keytab entry with a key using the first valid etype offered by the
> > server, then the authentication fails.
> 
> Errr, forgot to add [PATCH], here we go.
> 
> Cheers,
> 
> Stef

I only have two comments related to code style:

+    TALLOC_CTX *memctx;
+    int n_etype_list;
+
+    memctx = talloc_new (NULL);

We usually call such memory context tmp_ctx so that it's clear it's a
short-lived context used only inside this function.

+        krb5_get_init_creds_opt_set_etype_list (&options, etype_list,
                                               ^^^
We don't use a space between a function name and the arguments list.



More information about the sssd-devel mailing list