[SSSD] [PATCH] Modify behavior of pam_pwd_expiration_warning

Jan Zelený jzeleny at redhat.com
Thu May 3 11:08:05 UTC 2012


> On Tue, 2012-05-01 at 19:16 +0200, Jan Zeleny wrote:
> > - rename the option to pwd_expiration_warning
> > - move the option from PAM responder to domains
> > - if pwd_expiration_warning == 0, don't apply the filter at all
> > - default value for Kerberos: 7 days
> > - default value for LDAP: don't apply the filter
> > 
> > Technical note: default value when creating the domain is -1. This is
> > important so we can distinguish between "no value set" and 0. Without
> > this possibility it would be impossible to set different values for LDAP
> > and Kerberos provider.
> > 
> > https://fedorahosted.org/sssd/ticket/1140
> 
> Nack
> 
> We cannot remove options without a deprecation period. Please do not
> eliminate pam_pwd_expiration_warning. The better approach would be to
> treat it as a global setting that the domain-level
> pwd_expiration_warning options could override.
> 
> So setting pam_pwd_expiration_warning = 0 would be the same as saying
> all domains would never set the filter. And having neither
> pam_pwd_expiration_warning nor pwd_expiration_warning set would be "use
> the defaults for every domain".
> 
> Please change the documentation for the pwd_expiration_warning to make
> it clear that this is a limiter. The description for setting it to zero
> sounds like it's saying "never display the expiration warning".


I'm sending corrected patch, all your comments are addressed.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-128-1-pam_pwd_expiration_warning.patch
Type: text/x-patch
Size: 18061 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120503/0518f6b2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120503/0518f6b2/attachment.sig>


More information about the sssd-devel mailing list