[SSSD] [PATCH] Handle endianness issues on older systems

Stephen Gallagher sgallagh at redhat.com
Wed May 2 12:20:53 UTC 2012


On Wed, 2012-05-02 at 07:57 -0400, Jan Zeleny wrote:
> ----- Original Message -----
> > From: "Stephen Gallagher" <sgallagh at redhat.com>
> > To: "Development of the System Security Services Daemon" <sssd-devel at lists.fedorahosted.org>
> > Sent: Wednesday, May 2, 2012 1:04:17 AM
> > Subject: Re: [SSSD] [PATCH] Handle endianness issues on older systems
> > 
> > On Tue, 2012-05-01 at 17:23 -0400, Simo Sorce wrote:
> > > On Tue, 2012-05-01 at 16:32 -0400, Stephen Gallagher wrote:
> > > > Older versions of glibc (like that on RHEL 5) do not have the
> > > > le32toh() function exposed. We need this for handling the Active
> > > > Directory ID-mapping, so we'll copy these macros from endian.h on
> > > > a newer glibc.
> > > > 
> > > > This fixes the current broken RHEL 5 builds on master.
> > > 
> > > NACK,
> > > - please define only the ones you need
> > > - please ad them, to a common file, a whole new file is not needed
> > > unless you meant to keep it separated to give (C) credit, in which
> > > case
> > > NACK, you are putting your own (C) in there.
> > 
> > 
> > All valid points. Corrected (and much shorter) patch attached.
> 
> Ack,
> I haven't tested compilation on architectures different than x86 though.
> 
> Jan

Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120502/a907021f/attachment.sig>


More information about the sssd-devel mailing list