[SSSD] [PATCH] Handle endianness issues on older systems

Stephen Gallagher sgallagh at redhat.com
Tue May 1 23:04:17 UTC 2012


On Tue, 2012-05-01 at 17:23 -0400, Simo Sorce wrote:
> On Tue, 2012-05-01 at 16:32 -0400, Stephen Gallagher wrote:
> > Older versions of glibc (like that on RHEL 5) do not have the
> > le32toh() function exposed. We need this for handling the Active
> > Directory ID-mapping, so we'll copy these macros from endian.h on
> > a newer glibc.
> > 
> > This fixes the current broken RHEL 5 builds on master.
> 
> NACK,
> - please define only the ones you need
> - please ad them, to a common file, a whole new file is not needed
> unless you meant to keep it separated to give (C) credit, in which case
> NACK, you are putting your own (C) in there.


All valid points. Corrected (and much shorter) patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Handle-endianness-issues-on-older-systems.patch
Type: text/x-patch
Size: 1372 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120501/835ce7f2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120501/835ce7f2/attachment.sig>


More information about the sssd-devel mailing list