[SSSD] [PATCH] Fix off-by-one error in principal selection

Stephen Gallagher sgallagh at redhat.com
Thu Mar 29 19:03:12 UTC 2012


On Thu, 2012-03-29 at 15:00 -0400, Jakub Hrozek wrote:
> On Thu, Mar 29, 2012 at 02:27:36PM -0400, Stephen Gallagher wrote:
> > On Tue, 2012-03-27 at 15:27 -0400, Jakub Hrozek wrote:
> > > Just a one-liner but was not exactly easy to find..
> > > 
> > > https://fedorahosted.org/sssd/ticket/1269
> > 
> > Nack.
> > 
> > On close inspection, it looks like we're not properly truncating the
> > 'primary_str' variable after this. We're setting the NULL-terminator to
> > be after the asterisk, which is pretty much guaranteed to fail the
> > strncmp() on line 426.
> 
> The strncmp worked because we were only comparing tmp_len-1 bytes and
> never got to the asterisk. But it's confusing, I fixed the NULL
> terminator.

Ack for master and sssd-1-8.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120329/d44d1c4e/attachment.sig>


More information about the sssd-devel mailing list