[SSSD] [PATCH] Fix off-by-one error in principal selection

Stephen Gallagher sgallagh at redhat.com
Thu Mar 29 18:27:36 UTC 2012


On Tue, 2012-03-27 at 15:27 -0400, Jakub Hrozek wrote:
> Just a one-liner but was not exactly easy to find..
> 
> https://fedorahosted.org/sssd/ticket/1269

Nack.

On close inspection, it looks like we're not properly truncating the
'primary_str' variable after this. We're setting the NULL-terminator to
be after the asterisk, which is pretty much guaranteed to fail the
strncmp() on line 426.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120329/347b0776/attachment.sig>


More information about the sssd-devel mailing list