[SSSD] [PATCHES] Improve detection of attribute variances in IPA provider

Stephen Gallagher sgallagh at redhat.com
Wed Mar 28 17:19:05 UTC 2012


The IPA provider has its own set of dp_option and sdap_attr_map mappings
that we need to make sure remain in-sync with the standard LDAP
provider. In the past, we've just kept a "magic number" in a header file
that we need to remember to bump up every time we add a new option (or
down if we were to remove one).

With these patches, we will now make the checks much more robust
(checking not only for attribute count but also ordering).

Patch 0001: Put the attribute maps into their own header files so they
can be included by test tools. There is no functional change in this
patch.

Patch 0002: Add a terminator for the dp_option maps. This will allow us
to test them more simply.

Patch 0003: Add some better dp_option tests, allowing us to walk through
the map and verify that the option count is the same and that they are
in the same order.

Patch 0004: Similar to patch 0002, but for sdap_attr_map maps.

Patch 0005: Similar to patch 0003, but for sdap_attr_map maps.

Patch 0006: Remove old code that relied on the magic numbers. This patch
also drops the runtime option-count check, since we are always
performing the more complete check at build-time (as part of 'make
check', which is always run during distribution-builds as well as during
code-review).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Put-dp_option-maps-in-their-own-file.patch
Type: text/x-patch
Size: 73437 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-terminator-for-dp_option.patch
Type: text/x-patch
Size: 4271 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-better-dp_option-tests.patch
Type: text/x-patch
Size: 3545 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-terminator-for-sdap_attr_map.patch
Type: text/x-patch
Size: 12973 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-better-tests-for-sdap_attr-compability.patch
Type: text/x-patch
Size: 4430 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Remove-old-compatibility-tests.patch
Type: text/x-patch
Size: 4328 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120328/63f7302b/attachment.sig>


More information about the sssd-devel mailing list