[SSSD] [PATCH 0/4]: Actual memory cache implementation

Stephen Gallagher sgallagh at redhat.com
Wed Mar 7 12:11:37 UTC 2012


On Thu, 2012-01-12 at 11:49 -0500, Simo Sorce wrote:
> On Tue, 2012-01-10 at 14:33 -0500, Simo Sorce wrote:
> > On Tue, 2012-01-10 at 10:15 -0500, Simo Sorce wrote:
> > > > Sure, we can talk about it. I'm looking at it from the users'
> > > > perspectives, who I think would generally expect (and be alright
> > > with)
> > > > the fast cache being emptied on service restart. Since we still have
> > > the
> > > > not-quite-as-fast persistent LDB cache, I think the gain isn't worth
> > > the
> > > > user confusion.
> > > 
> > > Ok, I think I can understand this, it will also simplify the code I
> > > guess so I'll change the patch.
> > 
> > Attached new set of patches.
> > 
> > I changed the init code to always create a new cache file on restart,
> > incidentally this also got rid of the stat() call, so that problem has
> > been put to rest permanently :)
> > 
> > I also changed all functions to use errno_t as the return type in their
> > declaration when they return a errno code.
> > 
> > I think all the suggestions seen in the thread so far have been
> > implemented as requested at this point, with the exception of the part
> > where I should implement and use new options as that required additional
> > code instead of mere refactoring. I will add those features in a later
> > rebase.
> 
> New revision.
> 
> I removed bootid from the cache file header, given we recreate the file
> every time sssd restarts it was useles.
> 
> I replaced it with a seed, and made the seed used in the hash table
> randomly regenerated every time the hash table is recreated.
> 
> This is used to avoid collision based attacks [1].
> 
> Simo.
> 
> [1] https://lwn.net/Articles/474912/


I started looking at these last night. I have yet to complete a full
review, but I'm attaching a set of patches rebased atop the current
master so several of us can start reviewing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-util-Helper-headers-for-shared-memory-cache.patch
Type: text/x-patch
Size: 5940 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-nsssrv-shared-memory-cache-server-initialization.patch
Type: text/x-patch
Size: 18257 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-nsssrv-Add-memory-cache-record-handling-utils.patch
Type: text/x-patch
Size: 9369 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-nsssrv-add-handling-of-memory-cache-passwd-map.patch
Type: text/x-patch
Size: 6826 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-sss_client-Add-common-shared-memory-cache-utils.patch
Type: text/x-patch
Size: 11330 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-sss_client-shared-memory-cache-passwd-map-support.patch
Type: text/x-patch
Size: 10131 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-nsssrv-add-handling-of-memory-cache-group-map.patch
Type: text/x-patch
Size: 8258 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-sss_client-shared-memory-cache-group-map-support.patch
Type: text/x-patch
Size: 10331 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120307/aad1ac12/attachment.sig>


More information about the sssd-devel mailing list