[SSSD] [PATCH] DP: Reorganize memory hierarchy of requests

Stephen Gallagher sgallagh at redhat.com
Mon Mar 5 20:53:11 UTC 2012


On Fri, 2012-03-02 at 14:43 -0500, Simo Sorce wrote:
> On Fri, 2012-03-02 at 14:42 -0500, Stephen Gallagher wrote:
> > On Fri, 2012-03-02 at 14:40 -0500, Simo Sorce wrote:
> > > On Fri, 2012-03-02 at 14:19 -0500, Stephen Gallagher wrote:
> > > > On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
> > > > > This function alters the memory hierarchy of the be_req
> > > > > to ensure memory safety during shutdown. It creates a
> > > > > spy on the be_cli object so that it will free the be_req
> > > > > if the client is freed.
> > > > > 
> > > > > It is generally allocated atop the private data context
> > > > > for the appropriate back-end against which it is being
> > > > > filed.
> > > > > 
> > > > > This should resolve https://fedorahosted.org/sssd/ticket/1226
> > > > 
> > > > Simo performed the review on IRC and found one issue (the destructors
> > > > should not be set until both spies are active) and made a minor
> > > > improvement request.
> > > > 
> > > > New patch attached.
> > > > 
> > > Ok I promised an ACK if the minor improvement was there but NACK,
> > > destructors are set twice now, I guess a bad merge when preparing the
> > > patch ?
> > > 
> > > Simo.
> > > 
> > 
> > Fixed. Not sure how that happened.
> 
> Aaand ACK


Pushed to master and sssd-1-8.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120305/cf164c01/attachment.sig>


More information about the sssd-devel mailing list