[SSSD] [PATCH] DP: Reorganize memory hierarchy of requests

Simo Sorce simo at redhat.com
Fri Mar 2 19:40:45 UTC 2012


On Fri, 2012-03-02 at 14:19 -0500, Stephen Gallagher wrote:
> On Fri, 2012-03-02 at 13:52 -0500, Stephen Gallagher wrote:
> > This function alters the memory hierarchy of the be_req
> > to ensure memory safety during shutdown. It creates a
> > spy on the be_cli object so that it will free the be_req
> > if the client is freed.
> > 
> > It is generally allocated atop the private data context
> > for the appropriate back-end against which it is being
> > filed.
> > 
> > This should resolve https://fedorahosted.org/sssd/ticket/1226
> 
> Simo performed the review on IRC and found one issue (the destructors
> should not be set until both spies are active) and made a minor
> improvement request.
> 
> New patch attached.
> 
Ok I promised an ACK if the minor improvement was there but NACK,
destructors are set twice now, I guess a bad merge when preparing the
patch ?

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list