[SSSD] BUILD: Change default unicode library to glib2

Stephen Gallagher sgallagh at redhat.com
Mon Jun 25 13:35:52 UTC 2012


On Mon, 2012-06-25 at 15:34 +0200, Jan Zelený wrote:
> Dne pondělí 25 června 2012 09:30:58, Stephen Gallagher napsal(a):
> > On Mon, 2012-06-25 at 15:28 +0200, Jan Zelený wrote:
> > > Dne pondělí 25 června 2012 09:04:05, Stephen Gallagher napsal(a):
> > > > There is no longer any real advantage to building against libunistring
> > > > by default. This patch switches SSSD's build to use glib2 instead, which
> > > > will exist already on all platforms that SSSD is known to compile on.
> > > > This will eliminate an extra dependency on libunistring and save space
> > > > on capacity-limited systems.
> > > 
> > > You also remove cvs and nscd from BUILD.txt. Could you at least give a
> > > comment about that please?
> > 
> > I added a comment to the commit message. The 'cvs' requirement should
> > never have been there (and I'm not sure why it was). The 'nscd'
> > requirement was dropped a few months ago, but we forgot to remove it
> > from BUILD.txt.
> 
> Sorry, didn't notice the commit message.
> 
> Ack


I should have been more clear. The second patch I sent added that
message. It was missing from the original review :)

Thanks for the review. Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120625/b4b5f697/attachment.sig>


More information about the sssd-devel mailing list