[SSSD] [PATCH] Fix re_expression matching with subdomains

Sumit Bose sbose at redhat.com
Thu Jun 21 20:36:27 UTC 2012


On Thu, Jun 21, 2012 at 04:51:36PM +0200, Jan Zelený wrote:
> Dne čtvrtek 21 června 2012 12:23:30, Sumit Bose napsal(a):
> > On Thu, Jun 21, 2012 at 04:57:35AM -0400, Jan Zeleny wrote:
> > > ----- Original Message -----
> > > 
> > > > On Tue, 2012-06-19 at 17:15 +0200, Jan Zelený wrote:
> > > > > This patch fixes an issue which resulted in a need to initialize
> > > > > responder with data from local domain, otherwise it would not
> > > > > correctly
> > > > > detect requests for subdomains. Similar situation can occur if new
> > > > > subdomain is added at runtime.
> > > > > 
> > > > > The solution is to ask for a list of subdomains in case there is a
> > > > > candidate domain identified in the process of matching
> > > > > re_expressions
> > > > > with given name.
> > 
> > I tested the patch and it work fine. Even with a deleted cache file
> > sub-domain users where discovered as expected.
> > 
> > Maybe Stef should check if all his test cases works well with the patch.
> > > > Nack
> > > > 
> > > > You're copy-pasting the same bit of code around
> > > > sss_dp_get_domains_send() in quite a few places. Could you just wrap
> > > > these all in a common function and avoid all the reuse, please?
> > > 
> > > Well I suppose I can do that but the gain would not be that significant
> > > since all I do is basically error checking which would still need to be
> > > there. How about some kind of macro with one argument: callback name.
> > > Would that be acceptable?
> > Can you at least try to put the switch statement for the protocol
> > version into a function of it's own?
> > 
> > bye,
> > Sumit
> 
> Done

Thank you, patch is still working well. ACK

bye,
Sumit

> 
> Thanks
> Jan



More information about the sssd-devel mailing list