[SSSD] [PATCH][RFC] Fix lack of O_CLOEXEC in open()

Stephen Gallagher sgallagh at redhat.com
Thu Jun 21 19:27:19 UTC 2012


On Thu, 2012-06-21 at 13:24 -0400, Simo Sorce wrote:
> Old platforms like RHEL5 do not have this feature, this is a RFC about
> the way I propose handling it.
> 
> Although I generally do not like ifdefs in code and we could alwys use
> the fctnl method, I would like to avoid the fcntl when the platfroms
> suport the open options as this will remove 2 system calls. This is
> because this code is in the client and the cache is a fast path for us,
> so the less syscalls the faster.
> It also makes it very easy to remove the code later once we will drop
> support for things like RHEL5 ... eventually :)
> 
> Simo.
> 
> NB. it compiles on F17 but had not way to test it on an actual RHEL5,
> can someone do that please ?

Compiles cleanly on RHEL 5 and the patch looks good.

Ack and pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120621/66d060f2/attachment.sig>


More information about the sssd-devel mailing list