[SSSD] [PATCH] Fix re_expression matching with subdomains

Stephen Gallagher sgallagh at redhat.com
Wed Jun 20 20:03:32 UTC 2012


On Tue, 2012-06-19 at 17:15 +0200, Jan Zelený wrote:
> This patch fixes an issue which resulted in a need to initialize
> responder with data from local domain, otherwise it would not correctly
> detect requests for subdomains. Similar situation can occur if new
> subdomain is added at runtime.
> 
> The solution is to ask for a list of subdomains in case there is a
> candidate domain identified in the process of matching re_expressions
> with given name.
> 

Nack

You're copy-pasting the same bit of code around
sss_dp_get_domains_send() in quite a few places. Could you just wrap
these all in a common function and avoid all the reuse, please?

Also, I don't understand the point of the pam_forwarder_cb() changes.
Were those supposed to be a different patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120620/edde3ec2/attachment.sig>


More information about the sssd-devel mailing list