[SSSD] [PATCH]-Quiet down the startup of sssd

Stephen Gallagher sgallagh at redhat.com
Wed Jun 20 11:47:56 UTC 2012


On Tue, 2012-06-19 at 08:55 -0400, Stephen Gallagher wrote:
> On Thu, 2012-06-14 at 08:10 -0400, Stephen Gallagher wrote:
> > On Tue, 2012-06-12 at 23:22 -0500, Ariel Barria wrote:
> > > thanks for comments
> > > 
> > > 
> > > > Date: Tue, 12 Jun 2012 11:54:02 +0200
> > > > From: jhrozek at redhat.com
> > > > To: sssd-devel at lists.fedorahosted.org
> > > > Subject: Re: [SSSD] [PATCH]-Quiet down the startup of sssd
> > > > 
> > > > On Tue, Jun 12, 2012 at 11:10:46AM +0200, Jan Zelený wrote:
> > > > > > https://fedorahosted.org/sssd/ticket/1294
> > > > > 
> > > > > Nack,
> > > > > in general we don't like using the exit() function.
> > > > > 
> > > > 
> > > > Jan meant that it's bad manners to use exit() inside a function that
> > > you
> > > > have no idea how exactly will be used. Please only use exit when
> > > > terminating program from main(), or if you really need to quit
> > > because
> > > > of some very severe erorr.
> > > > 
> > > > > Also as I understand it, the intended solution was to change debug
> > > levels of 
> > > > > some DEBUG calls to the new format. See the bugzilla linked with
> > > the ticket.
> > > > 
> > > > Yes
> > 
> > 
> > Nack, for several reasons.
> > 
> > First, this patch is incomplete. There are far more places that need
> > adjusting than this single message.
> > 
> > Secondly, I didn't realize it until yesterday, but the original reporter
> > of this bug also submitted a proposed patch to fix it, which I'm
> > including here. I will review this patch today.
> > 
> > Thank you very much for your interest Ariel, sorry that this one didn't
> > really work out.
> 
> Ack.

Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120620/a2eaec3c/attachment.sig>


More information about the sssd-devel mailing list