[SSSD] [PATCH] Conditionalize support for DIR cache in the Kerberos provider

Stephen Gallagher sgallagh at redhat.com
Fri Jun 15 18:02:01 UTC 2012


On Fri, 2012-06-15 at 19:53 +0200, Jan Zeleny wrote:
> Stephen Gallagher <sgallagh at redhat.com> wrote:
> > 
> > All changes requested above have been made, including avoiding the
> > shadowing (in new patch 0003).
> > 
> > I've completed my testing to my satisfaction with no additional changes
> > except those that Jan requested in his review.
> 
> Nack,
> there is one more warning that you missed:
> 
> src/providers/krb5/krb5_utils.c: In function ‘get_cc_be_ops’:
> src/providers/krb5/krb5_utils.c:570:5: warning: enumeration value 
> ‘SSS_KRB5_TYPE_DIR’ not handled in switch [-Wswitch]
> 
> Also please use new debug levels in your patch #0003


As discussed on IRC, I opted to conditionalize SSS_KRB5_TYPE_DIR in the
enum and then also conditionalize the code where we were detecting the
type from the input. My original idea was that we should detect and warn
that it's not supported, but I think that's out of scope for now.

I also added a new patch adjusting the DEBUG macros as requested.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-compilation-on-older-little-endian-systems.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120615/35c7ef4b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-KRB5-Update-DEBUG-macros-for-create_ccache_dir-and-f.patch
Type: text/x-patch
Size: 5541 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120615/35c7ef4b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-KRB5-Auto-detect-DIR-cache-support-in-configure.patch
Type: text/x-patch
Size: 11290 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120615/35c7ef4b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-KRB5-Avoid-shadowing-dirname.patch
Type: text/x-patch
Size: 6215 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120615/35c7ef4b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120615/35c7ef4b/attachment.sig>


More information about the sssd-devel mailing list