[SSSD] [PATCH] Conditionalize support for DIR cache in the Kerberos provider

Jan Zelený jzeleny at redhat.com
Fri Jun 15 15:16:19 UTC 2012


> We only support the DIR cache on Kerberos 1.10 and higher. We need to
> make sure we still build and run on older systems.
> 
> Patch 0001: Minor fix for building on little-endian RHEL 5 systems.
> (Building for ppc was broken)
> 
> Patch 0002: Conditionalize DIR cache

Couple comments:

I see following warnings during compilation:
src/providers/krb5/krb5_utils.c: In function 'find_ccdir_parent_data':
src/providers/krb5/krb5_utils.c:246:72: warning: declaration of 'dirname' 
shadows a global declaration [-Wshadow]
src/providers/krb5/krb5_utils.c: In function 'create_ccache_dir':
src/providers/krb5/krb5_utils.c:335:31: warning: declaration of 'dirname' 
shadows a global declaration [-Wshadow]
src/providers/krb5/krb5_utils.c: In function 'create_ccache_dir_head':
src/providers/krb5/krb5_utils.c:531:11: warning: declaration of 'dirname' 
shadows a global declaration [-Wshadow]

in the patch #0002 there are some places in the patch where you have lines 
with SSS_KRB5_TYPE_DIR ifdefed and other places where it is outside the ifdef. 
Could you please fix that so it is everywhere the same?

Other than that everything compiles fine. However when I try to run it, sssd 
doesn't start and following message is in the log file:

sssd: Cannot load configuration database

Not sure if it's related but I started with clean setup, cache and logs 
deleted. Test suite works fine.

Thanks
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120615/f9db8589/attachment.sig>


More information about the sssd-devel mailing list