[SSSD] [PATCHES] Some assorted bugfixes and helpers

Jan Zelený jzeleny at redhat.com
Tue Jun 12 07:22:55 UTC 2012


> On Mon, 2012-06-11 at 13:35 +0200, Jan Zelený wrote:
> > > Sending patches in two parts. These first five are (I believe) ready
> > > for a complete review. I will send three more in a [PRELIMINARY]
> > > thread as well, since they require some discussion.
> > > 
> > > 
> > > Patch 0001: Fix the debug levels for some sysdb user and group lookups.
> > > Success was too noisy and failure was not noisy enough.
> > 
> > Ack
> > 
> > > Patch 0002: Remove block of code that appears twice in the same
> > > function. Looks like a copy-paste error.
> > 
> > Nack,
> > there is another block of code just below which should be removed as well
> > 
> > > Patch 0003: Fix incorrect switch statement in sdap_get_initgr_done()
> > > SDAP_SCHEMA_AD needs to be calling sdap_initgr_rfc2307bis_recv(),
> > > not sdap_initgr_nested_recv(). By coincidence both recv functions
> > > happened to be identical, but if one or the other changed, this
> > > would break unexpectedly.
> > 
> > Ack,
> > 
> > > Patch 0004: Add helper function to get list of a user's groups from
> > > sysdb
> > > This is being made into a function so it can be reused in one of the AD
> > > patches I'll be sending shortly.
> > 
> > Nack,
> > the first DEBUG string in get_sysdb_grouplist() is missing one argument
> > 
> > > Patch 0005: Make sdap_initgr_common_store() non-static
> > > Move it to a private header so it can be reused by other
> > > initgroups C files. This is being made public so it can be reused in my
> > > AD patches.
> > 
> > Ack
> 
> Thanks for the review. All comments addressed in the attached patches.

Ack to all five.

Thanks
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120612/755e2bba/attachment.sig>


More information about the sssd-devel mailing list