[SSSD] [PATCHES] Some assorted bugfixes and helpers

Stephen Gallagher sgallagh at redhat.com
Sun Jun 10 19:19:38 UTC 2012


Sending patches in two parts. These first five are (I believe) ready for
a complete review. I will send three more in a [PRELIMINARY] thread as
well, since they require some discussion.


Patch 0001: Fix the debug levels for some sysdb user and group lookups.
Success was too noisy and failure was not noisy enough.

Patch 0002: Remove block of code that appears twice in the same
function. Looks like a copy-paste error.

Patch 0003: Fix incorrect switch statement in sdap_get_initgr_done()
SDAP_SCHEMA_AD needs to be calling sdap_initgr_rfc2307bis_recv(),
not sdap_initgr_nested_recv(). By coincidence both recv functions
happened to be identical, but if one or the other changed, this
would break unexpectedly.

Patch 0004: Add helper function to get list of a user's groups from
sysdb
This is being made into a function so it can be reused in one of the AD
patches I'll be sending shortly.

Patch 0005: Make sdap_initgr_common_store() non-static
Move it to a private header so it can be reused by other
initgroups C files. This is being made public so it can be reused in my
AD patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SYSDB-Reduce-noise-level-of-debug-messages-in-lookup.patch
Type: text/x-patch
Size: 2246 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120610/861384b2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-LDAP-Remove-redundant-check.patch
Type: text/x-patch
Size: 1164 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120610/861384b2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-LDAP-Fix-incorrect-switch-statement-in-sdap_get_init.patch
Type: text/x-patch
Size: 1266 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120610/861384b2/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-LDAP-Add-helper-function-to-get-list-of-a-user-s-gro.patch
Type: text/x-patch
Size: 5700 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120610/861384b2/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-LDAP-Make-sdap_initgr_common_store-non-static.patch
Type: text/x-patch
Size: 2763 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120610/861384b2/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120610/861384b2/attachment.sig>


More information about the sssd-devel mailing list