[SSSD] [PATCH] Provide service filter for SELinux context

Jakub Hrozek jhrozek at redhat.com
Thu Jun 7 08:21:17 UTC 2012


On Thu, May 31, 2012 at 09:17:18PM +0200, Jan Zeleny wrote:
> At this moment we will support only asterisk, designating "all
> services".
> 
> https://fedorahosted.org/sssd/ticket/1360
> 
> Thanks
> Jan

Nack, you need to initialize services to NULL, otherwise if any
operation before the strdup failed, you would free random pointer.

You can also use sizeof(ALL_SERVICES)-1 and avoid defining
ALL_SERVICES_LEN (and be safe if ALL_SERVICES changed, not that it's
likely).

Does the SELinux feature work at all without the patch? If not, we
should consider moving the ticket to 1.8



More information about the sssd-devel mailing list