[SSSD] [PATCH] debug tests - allow changing cwd

Pavel Březina pbrezina at redhat.com
Thu Jul 26 07:53:56 UTC 2012


On 07/25/2012 04:36 PM, Jakub Hrozek wrote:
> On Wed, Jul 25, 2012 at 10:06:57AM +0200, Pavel Březina wrote:
>> On 07/23/2012 05:31 PM, Jakub Hrozek wrote:
>>> On Mon, Jul 23, 2012 at 02:32:44PM +0200, Pavel Březina wrote:
>>>> Debug tests does not call tests_set_cwd() to change current
>>>> directory to whatever was specified in configure.
>>>
>>> This works fine, but before pushing, I'm wondering about adding this
>>> statement to all tests so that if the unit tests are extended in the
>>> future and start writing out a file, the file gets written to the test
>>> directory.
>>
>> The only tests that miss this call aside of debug are krb5_child,
>> resolv and simple_access, The attached patch puts it in these tests
>> as well.
>
> Nack, this breaks the krb5_child-test.
>
> This test looks for the krb5_child binary to execute. I would argue that
> the krb5_child test is mainly targeted at developers, so the set_cwd()
> call is not necessary

OK, I removed it. New patch attached.

> Alternatively, you can change the way krb5_child-test searches for the
> krb5-child binary (-DKRB5_CHILD_DIR in Makefile.am)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-allow-changing-cwd-in-all-tests.patch
Type: text/x-patch
Size: 3261 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120726/43de3b9c/attachment.bin>


More information about the sssd-devel mailing list